Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: scann support iterator #992

Merged
merged 1 commit into from
Dec 24, 2024

Conversation

cqy123456
Copy link
Collaborator

@cqy123456 cqy123456 commented Dec 18, 2024

issue:#909

Copy link

mergify bot commented Dec 18, 2024

@cqy123456 🔍 Important: PR Classification Needed!

For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:

  1. If you're fixing a bug, label it as kind/bug.
  2. For small tweaks (less than 20 lines without altering any functionality), please use kind/improvement.
  3. Significant changes that don't modify existing functionalities should be tagged as kind/enhancement.
  4. Adjusting APIs or changing functionality? Go with kind/feature.

For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”.

Thanks for your efforts and contribution to the community!.

@@ -7,6 +7,8 @@
#include <faiss/utils/Heap.h>
#include <faiss/utils/distances.h>
#include <faiss/utils/utils.h>
#include <faiss/FaissHook.h>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove #include <faiss/FaissHook.h>

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.86%. Comparing base (3c46f4c) to head (a63a439).
Report is 278 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           main     #992       +/-   ##
=========================================
+ Coverage      0   73.86%   +73.86%     
=========================================
  Files         0       82       +82     
  Lines         0     6923     +6923     
=========================================
+ Hits          0     5114     +5114     
- Misses        0     1809     +1809     

see 82 files with indirect coverage changes

@alexanderguzhva
Copy link
Collaborator

lgtm overall

@alwayslove2013
Copy link
Collaborator

/lgtm

@cqy123456
Copy link
Collaborator Author

/hold hold until 2.5 release

Copy link
Collaborator

@foxspy foxspy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cqy123456, foxspy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@foxspy
Copy link
Collaborator

foxspy commented Dec 24, 2024

/unhold

@foxspy
Copy link
Collaborator

foxspy commented Dec 24, 2024

/kind improvement

@sre-ci-robot sre-ci-robot merged commit d448fd6 into zilliztech:main Dec 24, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants