Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update conan pack to save UT build time #994

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

cydrain
Copy link
Collaborator

@cydrain cydrain commented Dec 18, 2024

save UT build time from 29m to 12m

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cydrain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

mergify bot commented Dec 18, 2024

@cydrain 🔍 Important: PR Classification Needed!

For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:

  1. If you're fixing a bug, label it as kind/bug.
  2. For small tweaks (less than 20 lines without altering any functionality), please use kind/improvement.
  3. Significant changes that don't modify existing functionalities should be tagged as kind/enhancement.
  4. Adjusting APIs or changing functionality? Go with kind/feature.

For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”.

Thanks for your efforts and contribution to the community!.

Signed-off-by: Cai Yudong <[email protected]>
@cydrain cydrain force-pushed the caiyd_update_conan_pack branch from 536f96f to 3fa5f6e Compare December 18, 2024 09:40
@cydrain cydrain changed the title Update conan pack Update conan pack to save UT build time Dec 18, 2024
@cydrain
Copy link
Collaborator Author

cydrain commented Dec 18, 2024

/kind improvement

@cqy123456
Copy link
Collaborator

/lgtm

@cydrain
Copy link
Collaborator Author

cydrain commented Dec 18, 2024

/hold

@cydrain
Copy link
Collaborator Author

cydrain commented Dec 18, 2024

/unhold

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.87%. Comparing base (3c46f4c) to head (3fa5f6e).
Report is 271 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           main     #994       +/-   ##
=========================================
+ Coverage      0   73.87%   +73.87%     
=========================================
  Files         0       82       +82     
  Lines         0     6916     +6916     
=========================================
+ Hits          0     5109     +5109     
- Misses        0     1807     +1807     

see 82 files with indirect coverage changes

@sre-ci-robot sre-ci-robot merged commit c90443c into zilliztech:main Dec 18, 2024
12 checks passed
@cydrain cydrain deleted the caiyd_update_conan_pack branch December 18, 2024 13:34
cqy123456 pushed a commit to cqy123456/zilliztech-knowhere that referenced this pull request Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants