chore: review fixes

zimmerman-team · Jun 7, 2024 · ae3b4be · ae3b4be
1 parent 85079a4
commit ae3b4be
Show file tree

Hide file tree

Showing 6 changed files with 29 additions and 10 deletions.
diff --git a/src/app/modules/common/RichEditor/index.tsx b/src/app/modules/common/RichEditor/index.tsx
@@ -147,7 +147,6 @@ export const RichEditor = (props: {
           BOLD: {
             fontFamily: "GothamNarrow-Bold",
             fontWeight: "bold",
-            fontSize: "14px",
             lineHeight: "normal",
           },
         }}

diff --git a/src/app/modules/dataset-upload-module/upload-steps/finishedFragment.tsx b/src/app/modules/dataset-upload-module/upload-steps/finishedFragment.tsx
@@ -6,6 +6,9 @@ import { DatasetDataTable } from "app/modules/dataset-upload-module/component/da
 import { CssSnackbar, ISnackbarState } from "./previewFragment";
 import { ReactComponent as FullScreenIcon } from "../assets/full-screen.svg";
 import { ReactComponent as CloseFullScreenIcon } from "../assets/close-full-screen.svg";
+import { useRecoilState } from "recoil";
+import { homeDisplayAtom } from "app/state/recoil/atoms";
+import { ArrowBack } from "@material-ui/icons";
 
 interface Props {
   data: any[];
@@ -25,6 +28,8 @@ export default function FinishedFragment(props: Props) {
   const history = useHistory();
   const location = useLocation();
 
+  const [display, setDisplay] = useRecoilState(homeDisplayAtom);
+
   const setDatasetId = useStoreActions(
     (actions) => actions.charts.dataset.setValue
   );
@@ -77,6 +82,25 @@ export default function FinishedFragment(props: Props) {
 
   return (
     <div css={dataSetsCss}>
+      <Link
+        to={(() => {
+          setDisplay("data");
+          return location.search.includes("?fromHome=true") ? "/" : "/explore";
+        })()}
+        css={`
+          display: flex;
+          align-items: center;
+          font-size: 14px;
+          color: #231d2c;
+          text-decoration: none;
+          margin-top: 16px;
+          margin-bottom: 16px;
+          column-gap: 8px;
+        `}
+        data-cy="dataset-back-to-library-btn"
+      >
+        <ArrowBack fontSize={"small"} /> Back to Data Library
+      </Link>
       <div
         css={`
           width: 100%;
@@ -93,7 +117,7 @@ export default function FinishedFragment(props: Props) {
             font-size: 16px;
             font-family: "GothamNarrow-Bold", sans-serif;
             line-height: 19px;
-            margin-top: 29px;
+            margin-top: 19px;
           `}
         >
           {props.description}
@@ -104,7 +128,7 @@ export default function FinishedFragment(props: Props) {
             display: flex;
             margin-bottom: 12px;
             justify-content: space-between;
-            margin-top: 55px;
+            margin-top: 34px;
           `}
         >
           <div

diff --git a/src/app/modules/home-module/index.tsx b/src/app/modules/home-module/index.tsx
@@ -446,7 +446,6 @@ export default function HomeModule() {
           {displayGrid(searchValue as string, sortValue)}
         </div>
       </Container>
-      <Box height={500} />
       <HomeFooter />
     </React.Fragment>
   );

diff --git a/src/app/modules/report-module/sub-module/rowStructure/rowStructureDisplay.tsx b/src/app/modules/report-module/sub-module/rowStructure/rowStructureDisplay.tsx
@@ -135,7 +135,7 @@ export default function RowstructureDisplay(props: RowStructureDisplayProps) {
         width: 100%;
         height: 100%;
         position: relative;
-        margin-bottom: ${!viewOnlyMode ? "0px" : "50px"};
+        margin-bottom: ${!viewOnlyMode ? "0px" : "16px"};
       `}
     >
       <div

diff --git a/src/app/modules/report-module/views/create/index.tsx b/src/app/modules/report-module/views/create/index.tsx
@@ -322,9 +322,6 @@ export const PlaceHolder = (props: PlaceholderProps) => {
     return false;
   };
 
-  console.log(isDroppable(), "candrop");
-  console.log(itemDragIndex, "isItemDragging");
-
   return (
     <div
       data-cy="report-row-placeholder"

diff --git a/src/app/modules/report-module/views/preview/index.tsx b/src/app/modules/report-module/views/preview/index.tsx
@@ -188,7 +188,7 @@ export function ReportPreviewView(props: {
                 <div
                   key={"divider" + `${index}`}
                   css={`
-                    margin: 0 0 50px 0;
+                    margin: 0 0 16px 0;
                     height: 2px;
                     width: 100%;
                     background-color: #cfd4da;
@@ -228,7 +228,7 @@ export function ReportPreviewView(props: {
               />
             );
           })}
-        <Box height={45} />
+        <Box height={16} />
       </Container>
 
       {location.search.includes("?fromLanding=true") && !isAuthenticated ? (