Merge pull request #242 from zimmerman-team/fix/duplicate-asset-undef…

…ined fix: Duplicating an asset in detail page leads to undefined route
zimmerman-team · Oct 1, 2024 · d1cdfad · d1cdfad
2 parents 03ad7e2 + 9ee1a5f
commit d1cdfad
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 6 deletions.
diff --git a/src/app/modules/chart-module/__test__/chartSubheaderToolbar.test.tsx b/src/app/modules/chart-module/__test__/chartSubheaderToolbar.test.tsx
@@ -581,7 +581,7 @@ test("clicking duplicate button should duplicate chart", async () => {
   const mockedAxios = axios.get as jest.Mock;
   mockedAxios
     .mockResolvedValueOnce({
-      data: { id: "chart-id" },
+      data: { data: { id: "chart-id" } },
     } as AxiosResponse<any>)
     .mockResolvedValueOnce({ data: mockChartList });
   jest

diff --git a/src/app/modules/chart-module/components/chartSubheaderToolbar/index.tsx b/src/app/modules/chart-module/components/chartSubheaderToolbar/index.tsx
@@ -252,7 +252,7 @@ export function ChartSubheaderToolbar(
           storeInCrudData: true,
           filterString: "filter[order]=updatedDate desc",
         });
-        setDuplicatedChartId(response.data.id);
+        setDuplicatedChartId(response.data?.data?.id);
         setSnackbarState({
           ...snackbarState,
           open: true,

diff --git a/src/app/modules/dataset-module/component/datasetSubHeaderToolbar.tsx b/src/app/modules/dataset-module/component/datasetSubHeaderToolbar.tsx
@@ -110,7 +110,7 @@ export default function DatasetSubHeaderToolbar(
             onTryAgain: () => {},
           });
         }
-        setDuplicatedDatasetId(response.data.id);
+        setDuplicatedDatasetId(response.data?.data?.id);
         setSnackbarState({
           ...snackbarState,
           open: true,

diff --git a/src/app/modules/report-module/__test__/reportSubheaderToolbar.test.tsx b/src/app/modules/report-module/__test__/reportSubheaderToolbar.test.tsx
@@ -414,8 +414,10 @@ describe("Tests for tablet and desktop view", () => {
     const axiosMock = axios.get as jest.Mock;
 
     axiosMock
-      .mockResolvedValueOnce({ data: { id: "12345" } } as AxiosResponse<any>)
-      .mockResolvedValueOnce({ data: [] });
+      .mockResolvedValueOnce({
+        data: { data: { id: "12345" } },
+      } as AxiosResponse<any>)
+      .mockResolvedValueOnce({ data: { data: [] } });
     jest
       .spyOn(Router, "useParams")
       .mockReturnValue({ page: "12345", view: undefined });

diff --git a/src/app/modules/report-module/components/reportSubHeaderToolbar/index.tsx b/src/app/modules/report-module/components/reportSubHeaderToolbar/index.tsx
@@ -230,7 +230,7 @@ export function ReportSubheaderToolbar(
           storeInCrudData: true,
           filterString: "filter[order]=updatedDate desc",
         });
-        setDuplicatedReportId(response.data.id);
+        setDuplicatedReportId(response.data?.data?.id);
         setSnackbarState({
           ...snackbarState,
           open: true,