Wire in assertion that the appropriate product is created in Stripe #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See: #79 This is a big commit because it conflates the formatting changes from #89. That said, it's also significant in it's own right. The ClientSandbox now has the ability to query and assert against Stripe, so we will be able to write full integration tests. That said we _probably_ want to consider spinning out a fake Stripe API so that our tests don't _always_ perform a full end-to-end check. Perhaps in Coruru, if something like that doesn't exist already?
user512
reviewed
Jul 13, 2020
|
|
||
| products() { | ||
| return new Promise((resolve, reject) => { | ||
| this.stripe.products.list({limit: 100}, (err, products) => { |
There was a problem hiding this comment.
Is this limit: 100 from Stripe?
Nvm, it's like we do ?limit=100 and the default is 10.
https://stripe.com/docs/api/products/list#list_products-limit
There was a problem hiding this comment.
Yea, I figured 100 was a better default.
user512
approved these changes
Jul 13, 2020
|
I thought Coruro is used to test email, what do you have in mind in using Coruro to test product created in Stripe? |
|
Coruro's intent is to provide a seam for fake versions of external services. That can be email (in the case of coruro-mailcatcher) or it could be things like firebase or stripe or other such services. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: #79
This is a big commit because it conflates the formatting changes from
#89.
That said, it's also significant in it's own right. The ClientSandbox
now has the ability to query and assert against Stripe, so we will be
able to write full integration tests.
That said we probably want to consider spinning out a fake Stripe API
so that our tests don't always perform a full end-to-end check.
Perhaps in Coruru, if something like that doesn't exist already?