Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs #168

Closed
wants to merge 3 commits into from
Closed

Update docs #168

wants to merge 3 commits into from

Conversation

zancas
Copy link
Member

@zancas zancas commented Jan 25, 2025

I'm unclear on whether validator can now be used in place of miner, but I noticed that validator is used earlier in the doc, and then "miner" shows up later. Maybe we can just switch to "validator" in all cases?

@zancas zancas requested a review from idky137 January 25, 2025 02:25
@idky137
Copy link
Contributor

idky137 commented Jan 27, 2025

This is actually an important distinction, maybe it could be rewritten better though.

Zaino is taking over responsibility for serving all "non-miner" clients from zcashd, with this change, zebra is now only responsible for serving zaino or serving "miner clients" direct. So we should keep the distinction in the docs.

Copy link
Contributor

@idky137 idky137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

distinction between miner and non-miner clients should be kept as is important use case detail.

@zancas
Copy link
Member Author

zancas commented Jan 28, 2025

I understand that miner and non-miner are important distinctions.. my question was about changing all instances of the the word "miner" to "validator".

"miner" makes more sense in the context of zcashd but the word "validator" is used e.g. in the type system.

To put it another way, eventually there won't be any miners, but zaino will still be serving validators (once CrossLink lands).

@idky137
Copy link
Contributor

idky137 commented Feb 6, 2025

Ahh sorry I understand now. Yes I am with this change.

Copy link
Contributor

@idky137 idky137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, Im not sure if this will conflict with the name change PR though?

Copy link
Member Author

@zancas zancas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure about the term validator and am concerned that it's ambiguous.

@zancas zancas closed this Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants