Compact block cache pt3 #170
Open
+495
−324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idky137
added
the
ZGM2
Draft
pacu
requested changes
Jan 30, 2025
| @@ -54,8 +54,40 @@ impl NonFinalisedState { | |||
| config, | |||
| }; | |||
|
|
|||
| // If no_db is active wait for server to sync with p2p network. | |||
| if non_finalised_state.config.no_db | |||
There was a problem hiding this comment.
can this be factored out to a function of non_finalized_state that has meaningful name? It seems a pretty specific condition that is being described here.
| { | ||
| break; | ||
| } else { | ||
| println!(" - Validator syncing with network. Validator chain height: {}, Estimated Network chain height: {}", |
There was a problem hiding this comment.
should this be a log entry instead?
| @@ -286,8 +274,11 @@ impl NonFinalisedState { | |||
| }; | |||
| } | |||
|
|
|||
| // Refill from reorg_height[+1]. | |||
| for block_height in (reorg_height.0 + 1)..self.fetcher.get_blockchain_info().await?.blocks.0 | |||
| // Refill from max(reorg_height[+1], sapling_activation_height). | |||
There was a problem hiding this comment.
shouldn't you refill the cache from reorg_height - 1?
| let validator_height = self.fetcher.get_blockchain_info().await?.blocks.0; | ||
| for block_height in ((reorg_height.0 + 1) | ||
| .max(self.config.network.sapling_activation_height().0)) | ||
| ..=validator_height | ||
| { | ||
| // Either pop the reorged block or pop the oldest block in non-finalised state. |
There was a problem hiding this comment.
Document Reorg Logic outside code as well.
| { | ||
| self.status.store(StatusType::CriticalError.into()); | ||
| return Err(NonFinalisedStateError::Critical( | ||
| "Critical error in database. Closing NonFinalisedState" |
There was a problem hiding this comment.
Can the error be more self explanatory given that the conditions of the failure are well-known?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Final integration of the Compact Block Cache.
Height(u32)(zebra-chain). This is required to search LMDB height keys by order.