Skip to content

Commit

Permalink
Update kafka-clients and embedded-kafka to 3.8.1 (#1352)
Browse files Browse the repository at this point in the history
Make `zio-kafka-example` depend zio-kafka using `dependsOn` instead of `libraryDependencies` with a specific version to prevent dependency conflicts.

Also updates:

📦 Updates [org.apache.kafka:kafka-clients](https://kafka.apache.org)
from `3.8.0` to `3.8.1`
📦 Updates [io.github.embeddedkafka:embedded-kafka](https://github.com/embeddedkafka/embedded-kafka) from `3.8.0` to `3.8.1`
📜 [GitHub Release Notes](https://github.com/embeddedkafka/embedded-kafka/releases/tag/v3.8.1) - [Version Diff](embeddedkafka/embedded-kafka@v3.8.0...v3.8.1)


Co-authored-by: zio-scala-steward[bot] <145262613+zio-scala-steward[bot]@users.noreply.github.com>
Co-authored-by: Erik van Oosten <[email protected]>
  • Loading branch information
zio-scala-steward[bot] and erikvanoosten authored Oct 31, 2024
1 parent a70ca68 commit 79f1d3e
Showing 1 changed file with 10 additions and 6 deletions.
16 changes: 10 additions & 6 deletions build.sbt
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@ lazy val binCompatVersionToCompare =
compatVersion
}

lazy val kafkaVersion = "3.8.0"
lazy val embeddedKafkaVersion = "3.8.0" // Should be the same as kafkaVersion, except for the patch part
lazy val kafkaVersion = "3.8.1"
lazy val embeddedKafkaVersion = "3.8.1" // Should be the same as kafkaVersion, except for the patch part

lazy val kafkaClients = "org.apache.kafka" % "kafka-clients" % kafkaVersion
lazy val logback = "ch.qos.logback" % "logback-classic" % "1.5.12"
Expand Down Expand Up @@ -189,22 +189,26 @@ lazy val zioKafkaExample =
project
.in(file("zio-kafka-example"))
.enablePlugins(JavaAppPackaging)
// The `dependsOn` pulls in:
// "dev.zio" %% "zio-kafka" % "version",
// "dev.zio" %% "zio-kafka-testkit" % "version" % Test,
.dependsOn(zioKafka, zioKafkaTestkit % "test")
.settings(stdSettings("zio-kafka-example"))
.settings(publish / skip := true)
.settings(run / fork := false)
.settings(
libraryDependencies ++= Seq(
"dev.zio" %% "zio" % "2.1.11",
"dev.zio" %% "zio-kafka" % "2.8.3",
"dev.zio" %% "zio" % zioVersion.value,
"dev.zio" %% "zio-logging-slf4j2" % "2.3.2",
"io.github.embeddedkafka" %% "embedded-kafka" % embeddedKafkaVersion,
logback,
"dev.zio" %% "zio-kafka-testkit" % "2.8.3" % Test,
"dev.zio" %% "zio-test" % "2.1.11" % Test
"dev.zio" %% "zio-test" % zioVersion.value % Test
),
// Scala 3 compiling fails with:
// [error] Modules were resolved with conflicting cross-version suffixes in ProjectRef(uri("file:/home/runner/work/zio-kafka/zio-kafka/"), "zioKafkaExample"):
// [error] org.scala-lang.modules:scala-collection-compat _3, _2.13
// Prevent this error by excluding "scala-collection-compat" (see zio-kafka docs),
// or by skipping scala 3 completely.
crossScalaVersions -= scala3.value
)

Expand Down

0 comments on commit 79f1d3e

Please sign in to comment.