Add unit test for QueueSizeBasedFetchStrategy
#1017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guizmaii
reviewed
Aug 10, 2023
zio-kafka/src/main/scala/zio/kafka/consumer/internal/PartitionStreamControl.scala
Outdated
Show resolved
Hide resolved
svroonland
reviewed
Aug 12, 2023
zio-kafka-test/src/test/scala/zio/kafka/consumer/fetch/QueueSizeBasedFetchStrategySpec.scala
Show resolved
Hide resolved
|
@svroonland @guizmaii Can you take a look at this PR again please? |
erikvanoosten
force-pushed
the
fetchstrategy-unittest
branch
from
92309f2 to
c7f8ae2
Compare
svroonland
approved these changes
Oct 15, 2023
In addition, parameter `maxPartitionQueueSize` is now really a maximum and not the up-to-but-not-including value.
erikvanoosten
force-pushed
the
fetchstrategy-unittest
branch
from
c7f8ae2 to
08e1b1e
Compare
|
@guizmaii Sorry. I just noticed that we are still missing your approval as requested by @svroonland . Would you like me to roll this back? |
|
@erikvanoosten Steve's approval is enough. Thanks for asking 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces abstract class
PartitionStreamto only expose the relevant fields toFetchStrategy(also it makes it easier to create test values).