Fix Consumer.fromJavaConsumer and Producer.fromJavaProducer type signatures
#1033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mer that rely on interface instead of implementation
|
@devsprint What's the diff with the functions just above yours? 🤔 |
|
Just rely on the interface instead of implementation |
|
Not sure that is the best approach. maybe we can have a single method that use the interface as parameter instead of the implementation. |
Can you instead fix the previous functions? It's not good to rely on the implementation. The interfaces should have been used |
|
yes. I will update the branch in few minutes. |
|
(BTW, I'm fixing the CI here: #1032. I'll merge my PR as soon as the CI passes) |
svroonland
approved these changes
Aug 30, 2023
guizmaii
approved these changes
Aug 30, 2023
|
@devsprint I fixed the CI in the |
…mer that rely on interface instead of implementation
…rint/zio-kafka into enable-kafka-telemetry-integration
guizmaii
changed the title
Consumer.fromJavaConsumer and Producer.fromJavaProducer type signatures
|
Thanks @devsprint! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found the issue while trying to wrap the kafka Consumer and Producer with KafkaTelemetry to integrat Open Telemetry for tracing.
Added a pair of convenient methods.