feat: lint fuzz projects in CI #283
Conversation
which makes current nightly clippy fail.
it seems that they depends on cargo-afl, so we need to use `cargo afl clippy` instead of `cargo clippy`.
In this commit I replaced `self.path.join("/")` with
`self.path.join("")` because I think the expected result should be
the original path with trailing "/".
see: https://rust-lang.github.io/rust-clippy/master/index.html#join_absolute_paths
| BasicFileOperation::WriteDirectory(_) => Some(self.path.join("/")), | ||
| BasicFileOperation::WriteDirectory(_) => Some(self.path.join("")), |
There was a problem hiding this comment.
I am not sure whether this is intened. I guess in this line we want to return a path with trailing /, so I replaced the params with "".
see: https://rust-lang.github.io/rust-clippy/master/index.html#join_absolute_paths
There was a problem hiding this comment.
This probably isn't the correct behavior either. What's the correct way to append a / to a path? That's how we detect that it is, in fact, intended to be a directory and not a normal file. The documentation indicates, if I'm reading it correctly, that self.path.join("") doesn't do that and is instead a no-op. Maybe we need to append the / at some point while it's still a string-like type?
There was a problem hiding this comment.
The documentation indicates, if I'm reading it correctly, that
self.path.join("")doesn't do that and is instead a no-op.
I think self.path.join("") appends a / at the end of path. You can verify that with following code:
use std::path::PathBuf;
fn main() {
let original_path = PathBuf::from("/home/user");
let joined_path = original_path.join("");
println!("Original path: {:?}", original_path);
println!("Joined path: {:?}", joined_path);
assert_eq!(joined_path, PathBuf::from("/home/user/"));
}
This PR adds steps to run
cargo fmtandcargo clippytofuzz_writeandfuzz_read, also fixed some issues found byfmtandclippy.