-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Support for Ruby 3.2 #507
Conversation
Support for Ruby 3.2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. This is a beneficial update. The project benefits greatly by pushing this one out.
Notably, the version number would need a new MAJOR version.
Semantic versioning
@nicolaa Thanks for the contribution. I hope this gets merged eventually.
@cickes I don't think so. |
Looks like maybe https://github.com/stitchfix/rspec_api_documentation is the active fork to follow? |
We just upgraded to Ruby 3.3.0 |
Project needs to be adopted |
FWIW in https://github.com/rootstrap/rails_api_base we migrated to:
More info in https://github.com/rootstrap/rails_api_base/blob/main/docs/api_documentation.md |
These are some great libs @santib . But it would be good to have this lib back. |
@vladveterok @bf4 lots of requests for maintenance and little volunteering to do it... I don't think this PR passed travisCI originally which is why it was not merged quickly. Travis now requires payment even on free plan which is probably why it's been removed. I am not sure if there is an alternative these days for OSS CI builds that is still free. Happy to add anyone who wants to push some of these items forward ... @bf4 ? |
@jakehow Sure. I'll make a github actions test matrix pr on Wednesday if no one else has yet. (I'm afk right now) |
https://www.ruby-lang.org/en/news/2022/12/25/ruby-3-2-0-released/
Addresses #505