V2 CUMULATIVE with campaign and cutoff on the 7th of july

[RideSolo]

No description provided.

[Junochiu]

the code logic is looking good to me, left some comments for coding style

[Junochiu]

init snapshot is not used

Suggested change

	export type EVENT_TYPE = "point_increase" | "user_share" | "init_snapshot";
	export type EVENT_TYPE = "point_increase" | "user_share";

[Junochiu]

Suggested change

export const INIT_SNAPSHOT: EVENT_TYPE = "init_snapshot";

[Junochiu]

looks like the comment is outdated, and a suggestion we could make these three functions into a generic one with arguments for ctx and schema to make the code more concise.

Suggested change

	export async function getAllLPSnapshots(ctx : EthContext) {
	// removes the suffix comprised of two letters coming from POINT_SOURCE
	const snapshots = await ctx.store.list(AccountSnapshotLP)
	const addresses = snapshots.map((snapshot) => snapshot.id.toString());
	return {
	snapshots,
	addresses
	}
	}
	export async function getAllYTSnapshots(ctx : EthContext) {
	// removes the suffix comprised of two letters coming from POINT_SOURCE
	const snapshots = await ctx.store.list(AccountSnapshotYT)
	const addresses = snapshots.map((snapshot) => snapshot.id.toString());
	return {
	snapshots,
	addresses
	}
	}
	export async function getAllSYSnapshots(ctx : EthContext) {
	// removes the suffix comprised of two letters coming from POINT_SOURCE
	const snapshots = await ctx.store.list(AccountSnapshotSY)
	const addresses = snapshots.map((snapshot) => snapshot.id.toString());
	return {
	snapshots,
	addresses
	}
	}
	export async function getAllLPSnapshots(ctx : EthContext) {
	const snapshots = await ctx.store.list(AccountSnapshotLP)
	const addresses = snapshots.map((snapshot) => snapshot.id.toString());
	return {
	snapshots,
	addresses
	}
	}
	export async function getAllYTSnapshots(ctx : EthContext) {
	const snapshots = await ctx.store.list(AccountSnapshotYT)
	const addresses = snapshots.map((snapshot) => snapshot.id.toString());
	return {
	snapshots,
	addresses
	}
	}
	export async function getAllSYSnapshots(ctx : EthContext) {
	const snapshots = await ctx.store.list(AccountSnapshotSY)
	const addresses = snapshots.map((snapshot) => snapshot.id.toString());
	return {
	snapshots,
	addresses
	}
	}

[Junochiu]

suggestion for updatePointsYT and updatePointsYT from the code concise pov, I think we could use one function with default timeline for both, and just pass in the SY timeline when sy is calculated

[Junochiu]

changing the comparing branch to store, for easier review 🙏🏻 please feel free to change back as needed