Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add new error handling for user not found #216

Merged

Conversation

panapol-p
Copy link
Contributor

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • No debug or dead code
  • My code has no repetitions
  • Documentation/examples are up-to-date
  • All non-functional requirements are met
  • If possible, the test configuration is adjusted so acceptance tests cover my changes

after v2.54.0
POST http://127.0.0.1.sslip.io:8080/oauth/v2/token return Error.User.NotFound instead of assertion invalid

#210

@hifabienne hifabienne added the os-contribution This is a contribution from our open-source community label Jun 23, 2024
@fforootd
Copy link
Member

Hey @panapol-p thanks for the PR, let us look into this!

@panapol-p
Copy link
Contributor Author

FYI:

When we try to update the image to the latest version, Helm detects an error:
https://github.com/zitadel/zitadel-charts/actions/runs/9576027419/job/26401847046?pr=210#step:7:442

image

This error originates from

_, err = conn.Healthz(ctx, &mgmt_api.HealthzRequest{})

@eliobischof eliobischof changed the title feat: add new error handling for user not found test: add new error handling for user not found Jun 28, 2024
Copy link
Member

@eliobischof eliobischof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding and fixing this @panapol-p 🙏 LGTM

We'd like so send you small gift in return. If you like, please send us a mail to [email protected] so we can send you a link to a form with questions about your shirt size.

@eliobischof eliobischof merged commit b789afc into zitadel:main Jun 28, 2024
9 checks passed
@panapol-p panapol-p deleted the fix/add-error-handling-for-user-not-found branch June 28, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
os-contribution This is a contribution from our open-source community
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants