Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: helm chart bump.yml repair #236

Merged
merged 8 commits into from
Aug 23, 2024
Merged

chore: helm chart bump.yml repair #236

merged 8 commits into from
Aug 23, 2024

Conversation

rud
Copy link
Contributor

@rud rud commented Aug 23, 2024

With this my hope is the workflow started in #235 is now functional.

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • No debug or dead code
  • My code has no repetitions
  • Documentation/examples are up-to-date
  • All non-functional requirements are met
  • If possible, the test configuration is adjusted so acceptance tests cover my changes

@hifabienne hifabienne added the os-contribution This is a contribution from our open-source community label Aug 23, 2024
@eliobischof
Copy link
Member

Thanks, @rud
The changes make sense to me. Let's try 👍

@eliobischof eliobischof merged commit 913ac9d into zitadel:main Aug 23, 2024
9 checks passed
@eliobischof eliobischof mentioned this pull request Aug 27, 2024
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eliobischof eliobischof eliobischof approved these changes

Assignees
No one assigned
Labels
os-contribution This is a contribution from our open-source community
Projects
Product Management
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rud @eliobischof @hifabienne