Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra manifests #277

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

amine7777
Copy link

@amine7777 amine7777 commented Nov 28, 2024

This pull request introduces the capability to deploy additional Kubernetes manifests, such as External Secrets, using the Helm chart's extraManifests value. By leveraging this enhancement, users can now dynamically include custom manifests alongside the chart deployment, ensuring greater flexibility and streamlined resource management.

  • Added templating logic to support .Values.extraManifests for including custom YAML manifests.
  • Ensured proper YAML formatting with separators (---) for each additional manifest.

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • No debug or dead code
  • My code has no repetitions
  • Documentation/examples are up-to-date
  • All non-functional requirements are met
  • If possible, the test configuration is adjusted so acceptance tests cover my changes

@hifabienne hifabienne added the os-contribution This is a contribution from our open-source community label Nov 28, 2024
@fforootd
Copy link
Member

Thanks for this PR!

CC @eliobischof

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
os-contribution This is a contribution from our open-source community
Projects
Status: 👀 In review
Development

Successfully merging this pull request may close these issues.

3 participants