Skip to content

Commit

Permalink
Fix required checkboxes in issue forms (go-gitea#27592) (go-gitea#27692)
Browse files Browse the repository at this point in the history
Backport go-gitea#27592 by @JakobDev

If you set a checkbox as required in a issue form at the moment, the
checkbox is checked and read only, what does not make much sense. With
this PR, the Checkbox actually needs to be checked. The label supports
now also Markdown. This matches GitHub's behaviour.

And yes, I know the CSS is a ugly workaround. It looks like the given
CSS code is part Fomantic and I don't know how to change that. The
Maintainers are free to change that.


![grafik](https://github.com/go-gitea/gitea/assets/15185051/3f35be75-b0b4-42a7-9048-a4970384a035)

Co-authored-by: JakobDev <[email protected]>
  • Loading branch information
GiteaBot and JakobDev authored Oct 19, 2023
1 parent 89d3766 commit 6befca1
Showing 1 changed file with 7 additions and 4 deletions.
11 changes: 7 additions & 4 deletions templates/repo/issue/fields/checkboxes.tmpl
Original file line number Diff line number Diff line change
@@ -1,11 +1,14 @@
<div class="field">
{{template "repo/issue/fields/header" .}}
{{range $i, $opt := .item.Attributes.options}}
<div class="field">
<div class="ui checkbox">
<input type="checkbox" name="form-field-{{$.item.ID}}-{{$i}}" {{if $opt.required}}readonly checked{{end}}>
<label>{{$opt.label}}</label>
<div class="field inline">
<div class="ui checkbox gt-mr-0">
<input type="checkbox" name="form-field-{{$.item.ID}}-{{$i}}" {{if $opt.required}}required{{end}}>
<label>{{RenderMarkdownToHtml $.context $opt.label}}</label>
</div>
{{if $opt.required}}
<label class="required"></label>
{{end}}
</div>
{{end}}
</div>

0 comments on commit 6befca1

Please sign in to comment.