feat(precompiles): check negative values

zkBob · Dec 20, 2023 · 04a00c2 · 04a00c2
1 parent 410cce4
commit 04a00c2
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/crypto/src/main/java/org/tron/common/crypto/zksnark/Fp.java b/crypto/src/main/java/org/tron/common/crypto/zksnark/Fp.java
@@ -91,15 +91,15 @@ public class Fp implements Field<Fp> {
   static Fp create(byte[] v) {
     BigInteger value = new BigInteger(1, v);
     if (value.compareTo(P) >= 0) {
-      // Only the values less than P are valid
+      // Only the positive values less than P are valid
       return null;
     }
     return new Fp(toMontgomery(value));
   }
 
   static Fp create(BigInteger v) {
-    if (v.compareTo(P) >= 0) {
-      // Only the values less than P are valid
+    if (v.compareTo(P) >= 0 || v.signum() == -1) {
+      // Only the positive values less than P are valid
       return null;
     }
     return new Fp(toMontgomery(v));