feat(net): fix failure to process FETCH_INV_DATA message

zkBob · Aug 31, 2023 · e2fd664 · e2fd664
1 parent 03e903e
commit e2fd664
Showing 1 changed file with 12 additions and 12 deletions.
diff --git a/framework/src/main/java/org/tron/core/net/service/adv/AdvService.java b/framework/src/main/java/org/tron/core/net/service/adv/AdvService.java
@@ -41,11 +41,11 @@
 @Slf4j(topic = "net")
 @Component
 public class AdvService {
-
   private final int MAX_INV_TO_FETCH_CACHE_SIZE = 100_000;
   private final int MAX_TRX_CACHE_SIZE = 50_000;
   private final int MAX_BLOCK_CACHE_SIZE = 10;
   private final int MAX_SPREAD_SIZE = 1_000;
+  private final long TIMEOUT = MSG_CACHE_DURATION_IN_BLOCKS * BLOCK_PRODUCED_INTERVAL;
 
   @Autowired
   private TronNetDelegate tronNetDelegate;
@@ -264,13 +264,12 @@ private void consumerInvToFetch() {
     Collection<PeerConnection> peers = tronNetDelegate.getActivePeer().stream()
         .filter(peer -> peer.isIdle())
         .collect(Collectors.toList());
-
     InvSender invSender = new InvSender();
-    long now = System.currentTimeMillis();
     synchronized (this) {
       if (invToFetch.isEmpty() || peers.isEmpty()) {
         return;
       }
+      long now = System.currentTimeMillis();
       invToFetch.forEach((item, time) -> {
         if (time < now - MSG_CACHE_DURATION_IN_BLOCKS * BLOCK_PRODUCED_INTERVAL) {
           logger.info("This obj is too late to fetch, type: {} hash: {}", item.getType(),
@@ -279,15 +278,16 @@ private void consumerInvToFetch() {
           invToFetchCache.invalidate(item);
           return;
         }
-        peers.stream().filter(peer -> peer.getAdvInvReceive().getIfPresent(item) != null
-                && invSender.getSize(peer) < MAX_TRX_FETCH_PER_PEER)
-                .sorted(Comparator.comparingInt(peer -> invSender.getSize(peer)))
-                .findFirst().ifPresent(peer -> {
-                  if (peer.checkAndPutAdvInvRequest(item, now)) {
-                    invSender.add(item, peer);
-                  }
-                  invToFetch.remove(item);
-                });
+        peers.stream().filter(peer -> {
+          Long t = peer.getAdvInvReceive().getIfPresent(item);
+          return t != null && now - t < TIMEOUT && invSender.getSize(peer) < MAX_TRX_FETCH_PER_PEER;
+        }).sorted(Comparator.comparingInt(peer -> invSender.getSize(peer)))
+            .findFirst().ifPresent(peer -> {
+              if (peer.checkAndPutAdvInvRequest(item, now)) {
+                invSender.add(item, peer);
+              }
+              invToFetch.remove(item);
+            });
       });
     }