feat: range validation for factor setters

zkLend · Feb 19, 2024 · ae7a082 · ae7a082
1 parent cc1200b
commit ae7a082
Showing 1 changed file with 12 additions and 0 deletions.
diff --git a/src/market/external.cairo b/src/market/external.cairo
@@ -258,6 +258,12 @@ fn set_collateral_factor(
 ) {
     ownable::assert_only_owner(@self);
 
+    // Checks collateral_factor range
+    assert(
+        Into::<_, u256>::into(collateral_factor) <= safe_decimal_math::SCALE_U256,
+        errors::COLLATERAL_FACTOR_RANGE
+    );
+
     internal::assert_reserve_exists(@self, token);
     self.reserves.write_collateral_factor(token, collateral_factor);
     self
@@ -271,6 +277,12 @@ fn set_collateral_factor(
 fn set_borrow_factor(ref self: ContractState, token: ContractAddress, borrow_factor: felt252) {
     ownable::assert_only_owner(@self);
 
+    // Checks borrow_factor range
+    assert(
+        Into::<_, u256>::into(borrow_factor) <= safe_decimal_math::SCALE_U256,
+        errors::BORROW_FACTOR_RANGE
+    );
+
     internal::assert_reserve_exists(@self, token);
     self.reserves.write_borrow_factor(token, borrow_factor);
     self