Skip to content

Commit

Permalink
Fix typo (#143)
Browse files Browse the repository at this point in the history
* fix typo

* add typos fix
  • Loading branch information
miles-six authored Apr 15, 2024
1 parent 675358c commit 69ef080
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 9 deletions.
2 changes: 1 addition & 1 deletion contracts/dev-contracts/LZEndpointMock.sol
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ contract LZEndpointMock is ILayerZeroEndpoint {
uint public oracleFee;
bytes public defaultAdapterParams;

// path = remote addrss + local address
// path = remote address + local address
// inboundNonce = [srcChainId][path].
mapping(uint16 => mapping(bytes => uint64)) public inboundNonce;
// outboundNonce = [dstChainId][srcAddress]
Expand Down
2 changes: 1 addition & 1 deletion contracts/gateway/linea/LineaGateway.sol
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ abstract contract LineaGateway is BaseGateway, ILineaGateway {
/// @dev Bridge token to remote gateway
/// @param _token The token on local chain
/// @param _amount The token amount
/// @param _fee The fee payed to message service
/// @param _fee The fee paid to message service
/// @return Return native token and whether it is USDC
function bridgeERC20ToRemoteGateway(address _token, uint256 _amount, uint256 _fee) internal returns (bool, address) {
bool isUSDC;
Expand Down
2 changes: 1 addition & 1 deletion contracts/zksync/Events.sol
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ interface Events {
event Withdrawal(uint16 indexed tokenId, uint128 amount);

/// @notice Event emitted when user funds are withdrawn from the zkLink state but not from contract
event WithdrawalPending(uint16 indexed tokenId, bytes32 indexed recepient, uint128 amount);
event WithdrawalPending(uint16 indexed tokenId, bytes32 indexed recipient, uint128 amount);

/// @notice Event emitted when user funds are withdrawn from the zkLink state to a target contract
event WithdrawalCall(bytes32 indexed withdrawHash);
Expand Down
2 changes: 1 addition & 1 deletion contracts/zksync/PlonkCore.sol
Original file line number Diff line number Diff line change
Expand Up @@ -721,7 +721,7 @@ contract Plonk4VerifierWithAccessToDNext {
tmp_g1.point_sub_assign(vk.copy_permutation_commitments[STATE_WIDTH - 1].point_mul(last_permutation_part_at_z));

res.point_add_assign(tmp_g1);
// multiply them by v immedately as linearization has a factor of v^1
// multiply them by v immediately as linearization has a factor of v^1
res.point_mul_assign(state.v);
// res now contains contribution from the gates linearization and
// copy permutation part
Expand Down
2 changes: 1 addition & 1 deletion docs/Deploy.md
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ OPTIONS:
deployZkLink: Deploy zklink contracts
```

`--block-number`,`--genesis-root`,`--timestamp` are used to produce genesie block. When deploying for the first time `--block-number` and `--timestamp` can be left unset. When deploying for appending a new chain all these options need to be set with the latest exectuted block properties.
`--block-number`,`--genesis-root`,`--timestamp` are used to produce genesie block. When deploying for the first time `--block-number` and `--timestamp` can be left unset. When deploying for appending a new chain all these options need to be set with the latest executed block properties.

You could left `--validator` be unset when deploy to devnet or testnet, but **DOT NOT** use deployer address as network validator on the mainnet.

Expand Down
8 changes: 4 additions & 4 deletions docs/SecurityCheck.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ T2 - Use fixed compiler version to compile contract (SWC-103)

T3 - Check for correct inheritance, keep it simple and linear (SWC-125)

T4 - Constructor should not be exsited in proxyed contract
T4 - Constructor should not be existed in proxyed contract

T5 - Right-To-Left-Override control character not used (SWC-130)

Expand Down Expand Up @@ -126,7 +126,7 @@ L9 - Don't use msg.value repeatedly at delegatecall

### Token

A1 - Recipent-Withdraw pattern followed?
A1 - Recipient-Withdraw pattern followed?

A2 - Use call to send eth to a contract address and check the result (SWC-134)

Expand All @@ -136,7 +136,7 @@ A4 - Does msg.sender has the authority to move token of other addresses?

A5 - Use the balance difference as the amount when non-standard token deposit in or withdraw out of contract

A6 - Is there a possiblity that tokens can not be retrieved?
A6 - Is there a possibility that tokens can not be retrieved?

A7 - Is code is still correct if the token contract is upgradable?

Expand All @@ -150,7 +150,7 @@ O2 - Use TWP of onchain oracle

O3 - The price of LP is correct?

O4 - Is there a possiblity that lend a large amout of low-value token and manipulate its price to borrow a high-value token?
O4 - Is there a possibility that lend a large amount of low-value token and manipulate its price to borrow a high-value token?

## Reference

Expand Down

0 comments on commit 69ef080

Please sign in to comment.