Allow for escaped commas in CLI input #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zakird
approved these changes
May 5, 2023
zakird
reviewed
May 8, 2023
| s, err := r.Read() | ||
| if err != nil || len(s) == 0 { | ||
| return line, "" | ||
| } | ||
| if len(s) == 1 { |
There was a problem hiding this comment.
This feels like it is duplicative of L74?
| @@ -68,7 +69,11 @@ func parseMetadataInputLine(line string) (string, string) { | |||
| } | |||
|
|
|||
| func parseNormalInputLine(line string) (string, string) { | |||
| s := strings.SplitN(line, ",", 2) | |||
| r := csv.NewReader(strings.NewReader(line)) | |||
There was a problem hiding this comment.
Is this cheap enough that we're not worried about creating a new reader for every line? Docs look like expected to be reused across a whole file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #329
You're in luck, I was on a plane with Wifi and time to spare.