Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify code to use pty virtual serial devices #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kwrazi
Copy link

@kwrazi kwrazi commented Jun 12, 2018

No description provided.

@zmitchell
Copy link
Owner

Thanks for the pull request! I'm not familiar with the pty module, so I'm hesitant to accept this right now. I would also need to modify the other examples and update the accompanying blog post to keep everything in sync. If you wanted to make a new example using the pty module and explain what's going on, I would consider accepting that.

Unrelated to the PR, I've also discovered that you can do async serial much easier using the trio library. It provides an async file wrapper (read this), which you can use to wrap the serial.Serial class as it exposes the same API as a file object. Using that method the only difference between the sync and async code is a few awaits here and there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants