Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Give examples of using other build.yaml props #8

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

caksoylar
Copy link

Following up on zmkfirmware/zmk#2015, add an example using cmake-args and artifact-name to the comment blurb in build.yaml.

Here I used an alternate keymap example since that request comes up, e.g. zmkfirmware/zmk#1931. However it isn't the most straightforward since the path seems to be relative to zmk/app, hence the ../... Also KEYMAP_FILE isn't a documented arg.

An alternative would be to set a Kconfig for that build. Would that be preferable? If so, I can replace this with e.g. -DCONFIG_ZMK_USB_LOGGING=y.

build.yaml Outdated Show resolved Hide resolved
Copy link

@petejohanson petejohanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@petejohanson petejohanson merged commit 534e66b into zmkfirmware:main Dec 19, 2023
1 check passed
@caksoylar caksoylar deleted the example-with-props branch December 19, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants