-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Better Ubuntu font workaround (#274)
* Suppress some noisy tracing logs. * Better Ubuntu font workaround.
- Loading branch information
Showing
5 changed files
with
136 additions
and
45 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,93 @@ | ||
| use crate::{FontName, FontStretch, FontStyle, FontWeight}; | ||
|
|
||
| pub fn best(font_name: &FontName, style: FontStyle, weight: FontWeight, stretch: FontStretch) -> Option<font_kit::handle::Handle> { | ||
| if font_name == "Ubuntu" { | ||
| if let Some(h) = workaround_ubuntu(style, weight, stretch) { | ||
| return Some(h); | ||
| } | ||
| } | ||
|
|
||
| let family_name = font_kit::family_name::FamilyName::from(font_name.clone()); | ||
| match font_kit::source::SystemSource::new().select_best_match( | ||
| &[family_name], | ||
| &font_kit::properties::Properties { | ||
| style: style.into(), | ||
| weight: weight.into(), | ||
| stretch: stretch.into(), | ||
| }, | ||
| ) { | ||
| Ok(handle) => Some(handle), | ||
| Err(font_kit::error::SelectionError::NotFound) => { | ||
| tracing::debug!(target: "font_loading", "system font not found\nquery: {:?}", (font_name, style, weight, stretch)); | ||
| None | ||
| } | ||
| Err(e) => { | ||
| tracing::error!(target: "font_loading", "failed to select system font, {e}\nquery: {:?}", (font_name, style, weight, stretch)); | ||
| None | ||
| } | ||
| } | ||
| } | ||
|
|
||
| // see https://github.com/servo/font-kit/issues/245 | ||
| fn workaround_ubuntu(style: FontStyle, weight: FontWeight, stretch: FontStretch) -> Option<font_kit::handle::Handle> { | ||
| let source = font_kit::source::SystemSource::new(); | ||
| let ubuntu = source.select_family_by_name("Ubuntu").ok()?; | ||
| for handle in ubuntu.fonts() { | ||
| let font = handle.load().ok()?; | ||
| let name = font.postscript_name()?; | ||
|
|
||
| // Ubuntu-ExtraBold | ||
| // Ubuntu-Condensed | ||
| // Ubuntu-CondensedLight | ||
| // Ubuntu-CondensedBold | ||
| // Ubuntu-CondensedMedium | ||
| // Ubuntu-CondensedExtraBold | ||
| // UbuntuItalic-CondensedLightItalic | ||
| // UbuntuItalic-CondensedItalic | ||
| // UbuntuItalic-CondensedMediumItalic | ||
| // UbuntuItalic-CondensedBoldItalic | ||
| // UbuntuItalic-CondensedExtraBoldItalic | ||
| // Ubuntu-Italic | ||
| // UbuntuItalic-ThinItalic | ||
| // UbuntuItalic-LightItalic | ||
| // UbuntuItalic-Italic | ||
| // UbuntuItalic-MediumItalic | ||
| // UbuntuItalic-BoldItalic | ||
| // UbuntuItalic-ExtraBoldItalic | ||
| // UbuntuItalic-CondensedThinItalic | ||
| // Ubuntu-Thin | ||
| // Ubuntu-Regular | ||
| // Ubuntu-Light | ||
| // Ubuntu-Bold | ||
| // Ubuntu-Medium | ||
| // Ubuntu-CondensedThin | ||
|
|
||
| if (style == FontStyle::Italic) != name.contains("Italic") { | ||
| continue; | ||
| } | ||
|
|
||
| if (FontWeight::MEDIUM..FontWeight::SEMIBOLD).contains(&weight) != name.contains("Medium") { | ||
| continue; | ||
| } | ||
| if (weight >= FontWeight::EXTRA_BOLD) != name.contains("ExtraBold") { | ||
| continue; | ||
| } | ||
| if (FontWeight::SEMIBOLD..FontWeight::EXTRA_BOLD).contains(&weight) != name.contains("Bold") { | ||
| continue; | ||
| } | ||
|
|
||
| if (FontWeight::EXTRA_LIGHT..FontWeight::LIGHT).contains(&weight) != name.contains("Light") { | ||
| continue; | ||
| } | ||
| if (weight < FontWeight::EXTRA_LIGHT) != name.contains("Thin") { | ||
| continue; | ||
| } | ||
|
|
||
| if (stretch <= FontStretch::CONDENSED) != name.contains("Condensed") { | ||
| continue; | ||
| } | ||
|
|
||
| return Some(handle.clone()); | ||
| } | ||
| None | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters