Fix datastore types #195
Merged
Fix datastore types #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It should work fine with nested structs as well, but you can't let it be a pointer in the datastore structure. |
zond
reviewed
Jun 13, 2024
| ChatLanguageISO639_1 string `methods:"POST,PUT"` | ||
| GameMasterEnabled bool `methods:"POST"` | ||
| RequireGameMasterInvitation bool `methods:"POST,PUT"` | ||
| DiscordWebhooks *DiscordWebhooks `methods:"POST" datastore:",noindex"` |
There was a problem hiding this comment.
Just removing the * should make it work I think.
There was a problem hiding this comment.
Done. Tested locally and it worked. thanks!
There was a problem hiding this comment.
But wait, doesn't that mean that it's a required field? I don't want to break existing create game ux
There was a problem hiding this comment.
Go will just default it to the empty value, which in this case will be two empty strings. And datastore works the same way, so nothing will break :D
All old games will just have empty values in those fields.
added 2 commits
June 13, 2024 13:21
…ond/diplicity into johnpooch/add-webhooks-to-game
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@zond apologies. It appears appengine prefers primitive type. Maybe there's another way, but this seems to work.