ci(check-ci-skip): fix commitMessagesMetadata.forEach is not a function

Primary Changes ---------------- 1. Added condition to commitMessagesMetadata to check if commit message is array or not. Fixes hyperledger-cacti#3614 Signed-off-by: bado <[email protected]>
zondervancalvez · Nov 5, 2024 · 1178be7 · 1178be7
1 parent deb5073
commit 1178be7
Showing 1 changed file with 10 additions and 4 deletions.
diff --git a/tools/ci-skip-for-maintainers.js b/tools/ci-skip-for-maintainers.js
@@ -33,10 +33,16 @@ const main = async () => {
     pullReqUrl + "/commits",
   );
 
-  commitMessagesMetadata.forEach((commitMessageMetadata) => {
-    // get commit message body
-    commitMessageList.push(commitMessageMetadata["commit"]["message"]);
-  });
+  if (Array.isArray(commitMessagesMetadata)) {
+    commitMessagesMetadata.forEach((commitMessageMetadata) => {
+      // get commit message body
+      commitMessageList.push(commitMessageMetadata["commit"]["message"]);
+    });
+  } else {
+    console.error(
+      "Fetching data from github API failed. This is most likely due to an intermittent issue from Github end or the api being rate limited (one hour cooldown). Please retry running the failed check after an hour.",
+    );
+  }
 
   // Check if skip-ci is found in commit message
   const checkSkipCI = () => {