fix: handle read preferences without tags

zookzook · Sep 19, 2023 · 50ea98d · 50ea98d
1 parent 9e4d569
commit 50ea98d
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/lib/mongo/url_parser.ex b/lib/mongo/url_parser.ex
@@ -236,6 +236,10 @@ defmodule Mongo.UrlParser do
     end
   end
 
+  defp parse_tags([]) do
+    []
+  end
+
   defp parse_tags(tags) do
     tags
     |> String.split(",")

diff --git a/test/mongo/url_parser_test.exs b/test/mongo/url_parser_test.exs
@@ -124,6 +124,15 @@ defmodule Mongo.UrlParserTest do
                ]
              ]
 
+      assert UrlParser.parse_url(url: "mongodb://seed1.domain.com:27017,seed2.domain.com:27017/db_name?readPreference=secondary&maxStalenessSeconds=30") == [
+               database: "db_name",
+               read_preference: %{mode: :secondary, max_staleness_ms: 30_000},
+               seeds: [
+                 "seed1.domain.com:27017",
+                 "seed2.domain.com:27017"
+               ]
+             ]
+
       assert UrlParser.parse_url(url: "mongodb://seed1.domain.com:27017,seed2.domain.com:27017/db_name?readPreference=weird&readPreferenceTags=dc:ny,rack:r&maxStalenessSeconds=30") == [
                database: "db_name",
                seeds: [
-Original file line number
+Diff line change
@@ Expand Up / @@ -236,6 +236,10 @@ defmodule Mongo.UrlParser do @@
         end
       end
+      defp parse_tags([]) do
+        []
+      end
       defp parse_tags(tags) do
         tags
         |> String.split(",")
@@ Expand Down @@