Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(master): ensure url_parser does not fail on missing txt record #261

Merged
merged 4 commits into from
Dec 11, 2024
Merged

fix(master): ensure url_parser does not fail on missing txt record #261

merged 4 commits into from
Dec 11, 2024

Conversation

kkerezsi
Copy link
Contributor

@kkerezsi kkerezsi commented Dec 10, 2024 •
edited
Loading

Changes:

  • use :inet_res.lookup instead of :inet_res.getbyname to prevent failures on missing txt records when resolving the connection string

The following code fixes issue #260

zookzook
zookzook approved these changes Dec 10, 2024
View reviewed changes
lib/mongo/url_parser.ex Outdated Show resolved Hide resolved
@kkerezsi kkerezsi marked this pull request as ready for review December 11, 2024 06:22
@zookzook zookzook merged commit e4a3102 into zookzook:master Dec 11, 2024
5 checks passed
@zookzook
Copy link
Owner

Thank you!

@github-actions github-actions bot mentioned this pull request Dec 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CiprianAnton CiprianAnton CiprianAnton approved these changes

@zookzook zookzook zookzook approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kkerezsi @zookzook @CiprianAnton @alexkerezsini