Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect PURE_PYTHON environment variable set to 0 #158

Merged
merged 3 commits into from
Sep 30, 2024

Conversation

perrinjerome
Copy link
Contributor

Setting to 0 should be equivalent to not setting the variable.

Refs zopefoundation/meta#283

Setting to 0 should be equivalent to not setting the variable.

Refs zopefoundation/meta#283
@perrinjerome perrinjerome changed the title Respect PURE_PYTHON=0 environment variable Respect PURE_PYTHON environment variable set to 0 Sep 30, 2024
Copy link
Contributor

@d-maurer d-maurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AccessControl.Implementation contains a definition of PURE_PYTHON. In my view, this definition should be used for the tests as well (rather than reimplement the logic).

@perrinjerome
Copy link
Contributor Author

Thanks @d-maurer that makes sense, I have addressed this suggestion.

@perrinjerome perrinjerome merged commit 94282bd into master Sep 30, 2024
47 checks passed
@perrinjerome perrinjerome deleted the perrinjerome/PURE_PYTHON branch September 30, 2024 10:26
@perrinjerome
Copy link
Contributor Author

Thank you for the review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants