Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix methods get, pop, setdefault and __contains__ to not hide POSKeyError #162

Merged
merged 1 commit into from
Apr 9, 2021
Merged

Fix methods get, pop, setdefault and __contains__ to not hide POSKeyError #162

merged 1 commit into from
Apr 9, 2021

Conversation

jamadden
Copy link
Member

@jamadden jamadden commented Apr 7, 2021

Fixes #161

@jamadden jamadden requested a review from icemac April 8, 2021 10:26
icemac
icemac approved these changes Apr 9, 2021
View reviewed changes
Copy link
Member

@icemac icemac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay from reading the code.

@jamadden
Copy link
Member Author

jamadden commented Apr 9, 2021

Thank you!

@jamadden jamadden merged commit 41cc91b into master Apr 9, 2021
@jamadden jamadden deleted the issue161 branch April 9, 2021 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@icemac icemac icemac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BTree.get() swallows POSKeyError on internal corruption (C only)
2 participants
@jamadden @icemac