Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Windows wheels on GHA #41

Merged
merged 2 commits into from
May 25, 2024
Merged

Conversation

dataflake
Copy link
Member

@dataflake dataflake commented May 24, 2024

@dataflake dataflake requested review from icemac and d-maurer May 24, 2024 12:22
@dataflake dataflake self-assigned this May 24, 2024
@dataflake dataflake marked this pull request as ready for review May 24, 2024 12:35
Copy link
Contributor

@d-maurer d-maurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "manylinux" tests are suboptimally named: they have "3.9" in their name but in fact test all Python versions. I suggest we remove the "3.9".

The "manylinux (3.9, manylinux2014_aarch64)" fails for Py313 potentially related to a cffi problem:

py313: install_package_deps> python -I -m pip install --pre 'ExtensionClass>=4.6' 'persistent>=4.1.1' zope.testrunner --pre
  error: subprocess-exited-with-error
  
  × python setup.py egg_info did not run successfully.
...
       File "src/persistent/_ring_build.py", line 20, in <module>
          ffi = FFI()
        File "/tmp/pip-install-cvphmu6t/persistent_598761c24fc6479d844a1d87d7933402/.eggs/cffi-1.16.0-py3.13-linux-aarch64.egg/cffi/api.py", line 48, in __init__
          import _cffi_backend as backend
      ImportError: /tmp/pip-install-cvphmu6t/persistent_598761c24fc6479d844a1d87d7933402/.eggs/cffi-1.16.0-py3.13-linux-aarch64.egg/_cffi_backend.cpython-313-aarch64-linux-gnu.so: undefined symbol: _PyErr_WriteUnraisableMsg

@dataflake
Copy link
Member Author

I have created zopefoundation/meta#245 for the naming issue. The failing test is not a blocker, it should resolve itself when cffi finally has a release that is Python 3.13 compatible.

@dataflake dataflake requested a review from d-maurer May 25, 2024 08:57
@dataflake dataflake merged commit 9ccad44 into master May 25, 2024
57 of 58 checks passed
@dataflake dataflake deleted the config-with-c-code-template-4dc0484e branch May 25, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants