Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHA step naming #245

Closed
dataflake opened this issue May 25, 2024 · 3 comments
Closed

GHA step naming #245

dataflake opened this issue May 25, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@dataflake
Copy link
Member

The manylinux steps on GHA contain a Python version name (currently 3.9) but they build and/or test for all supported Python versions so the name is confusing. @icemac Is it OK if I at least change the name to drop the Python version?

@dataflake dataflake added the enhancement New feature or request label May 25, 2024
@dataflake dataflake self-assigned this May 25, 2024
@dataflake dataflake changed the title manylinux GHA step naming GHA step naming May 25, 2024
@dataflake
Copy link
Member Author

Another suggestion: The publicly visible names also include the specific GHA runner description, so whenever those change all packages must be touched to fix the branch protection rules. The specific runner name, like ubuntu-latest, isn't interesting to package users, only to us as maintainers of test matrices.

I suggest renaming all those steps to be more generic and include the Python version and a simple moniker added like Linux, macOS or Windows.

@dataflake
Copy link
Member Author

I did a little research and don't see how those names can be influenced. There's no way to use an aliased "friendly" name for the information GH displays.

@icemac
Copy link
Member

icemac commented May 28, 2024

@dataflake Thank you for your investigation. I also would have liked to change the names as updating requires changing the branch protection but this is now less of a hassle as we can do it automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants