Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update meta/config template to publish Windows wheels to PyPI #198

Merged
merged 1 commit into from
May 25, 2024
Merged

Update meta/config template to publish Windows wheels to PyPI #198

merged 1 commit into from
May 25, 2024

Conversation

dataflake
Copy link
Member

@dataflake dataflake requested review from icemac and d-maurer May 24, 2024 13:09
@dataflake dataflake self-assigned this May 24, 2024
@dataflake dataflake mentioned this pull request May 24, 2024
Closed
14 tasks
d-maurer
d-maurer approved these changes May 25, 2024
View reviewed changes
Copy link

@d-maurer d-maurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need individual reviews for application of a "meta/config" template?
@tseaver merge without review with the justification "I only applied the template and all tests pass". I find this okay.

@dataflake
Copy link
Member Author

Do we need individual reviews for application of a "meta/config" template? @tseaver merge without review with the justification "I only applied the template and all tests pass". I find this okay.

I agree and won't ask for reviews anymore if the change is small and the tests all pass. I was just following @icemac's habit.

@dataflake dataflake merged commit ec5f1a0 into master May 25, 2024
59 checks passed
@dataflake dataflake deleted the config-with-c-code-template-4dc0484e branch May 25, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-maurer d-maurer d-maurer approved these changes

@icemac icemac Awaiting requested review from icemac

Assignees

@dataflake dataflake

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dataflake @d-maurer