-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: pure python build #94
Conversation
We can't properly test the 'PURE_PYTHON=1' case if the C extensions are built in-place in the package.
Fix a test which relied on the extension being importable due to 'usedevlop = true' in 'tox.ini'. Closes #93.
Introduced in zopefoundation/meta#250
The wheel is already built - for pypy. The item "zodbpickle-Linux-pypy-3.10.whl" in the artifacts list for the GHA is a zip file that expands to "zodbpickle-4.1.dev0-py3-none-any.whl" when unzipped. However, the step "Publish package to PyPI (Non-Linux)" makes an explicit exception that won't upload the wheel for pypy: Removing that exception would upload the |
@dataflake I'm unclear why we even build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from reading the diff.
PURE_PYTHON=1
is set in the environment.Note that wheels built with
PURE_PYTHON=1
set will be 'py3-none-any` wheels. I'm not sure whether this PR should update the GHA workflow to cause such a wheel to be built.