Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build Windows wheels on GHA #46

Merged
merged 2 commits into from
May 24, 2024
Merged

Build Windows wheels on GHA #46

merged 2 commits into from
May 24, 2024

Conversation

dataflake
Copy link
Member

@dataflake dataflake requested review from icemac and d-maurer May 24, 2024 11:10
@dataflake dataflake self-assigned this May 24, 2024
@dataflake dataflake mentioned this pull request May 24, 2024
Closed
14 tasks
tseaver
tseaver reviewed May 24, 2024
View reviewed changes
docs/conf.py Show resolved Hide resolved
tseaver
tseaver approved these changes May 24, 2024
View reviewed changes
Copy link
Member

@tseaver tseaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked further, and couldn't find a sign that docs/config.py was being overwritten by the meta tools, so..... LGTM.

@tseaver tseaver enabled auto-merge May 24, 2024 21:25
@tseaver tseaver merged commit e22fd8a into master May 24, 2024
60 checks passed
@tseaver tseaver deleted the config-with-c-code-template-4dc0484e branch May 24, 2024 21:41
@dataflake
Copy link
Member Author

I looked further, and couldn't find a sign that docs/config.py was being overwritten by the meta tools, so..... LGTM.

I made that change manually in reaction to a warning message during the tox run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tseaver tseaver tseaver approved these changes

@icemac icemac Awaiting requested review from icemac

@d-maurer d-maurer Awaiting requested review from d-maurer

Assignees

@dataflake dataflake

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dataflake @tseaver