Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preliminary support for Python 3.14a2. #335

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

icemac
Copy link
Member

@icemac icemac commented Nov 26, 2024

I hacked something together so the tests do not fail for Python 3.14.
But I am completly unsure if this is the way we want/should go.

Fixes #334.

@dataflake
Copy link
Member

I can see the fix for that missing __classdictcell__ slot, but what's the IByteString change for?

Also, if you only want to test "is this Python 3.14", why do you need all those definitions for the older versions?

Copy link
Contributor

@d-maurer d-maurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you remove the IByteString definitions (in common.builtins and common.collections) for Python 3.14? The interface is likely useful for that version as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test failure with Python 3.14
3 participants