-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address (Pointer) scanner #93
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fix bug where value narrowing was filtering out too many variables from the UI end. Also add filtering for heap/stack memory to backend.
Annotating variable addresses with base() more clearly communicates it's a static address. Also only pretty old games/apps don't have ASLR or a slide.
We can get many many static results back so we will have to later track the static executables in the search results. For now I also temporarily disabled showing static results while progress is advancing because that is done too frequently.
This is to avoid main queue being overloaded with progress requests too much.
Also fix an issue for Rosetta processes where we were not using correct page size for region alignment for narrowing searches.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are a large batch of changes searching for variables whose address is composed of multiple levels of indirection / pointers. There are a lot of other miscellaneous fixes and changes here too so I'm just going to merge this once it passes the CI build.