Implement link copying option for PDF view context menu

Fixes zotero/zotero#3494
zotero · Oct 14, 2024 · 1918a73 · 1918a73
1 parent ffc5593
commit 1918a73
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 1 deletion.
diff --git a/src/common/context-menu.js b/src/common/context-menu.js
@@ -91,6 +91,15 @@ export function createViewContextMenu(reader, params) {
 		x: params.x,
 		y: params.y,
 		itemGroups: createItemGroup([
+			[
+				{
+					label: reader._getString('pdfReader.copyLink'),
+					disabled: !(params.overlay && params.overlay.type === 'external-link' && !reader.canCopy),
+					onCommand: () => {
+						navigator.clipboard.writeText(params.overlay.url);
+					}
+				}
+			],
 			[
 				{
 					label: reader._getString('general.copy'),

diff --git a/src/en-us.strings.js b/src/en-us.strings.js
@@ -191,6 +191,7 @@ export default {
 	'pdfReader.convertToUnderline': 'Convert to Underline',
 	'pdfReader.size': 'Size',
 	'pdfReader.merge': 'Merge',
+	'pdfReader.copyLink': 'Copy Link',
     'pdfReader.a11yAnnotationModifierMac': 'Option',
     'pdfReader.a11yAnnotationModifier': 'Alt',
     'pdfReader.a11yAnnotationModifierControl': 'Control',

diff --git a/src/pdf/pdf-view.js b/src/pdf/pdf-view.js
@@ -1680,7 +1680,11 @@ class PDFView {
 				if (this._selectedAnnotationIDs.length !== 0) {
 					this._onSelectAnnotations([], event);
 				}
-				this._onOpenViewContextMenu({ x: br.x + event.clientX, y: br.y + event.clientY });
+				let overlay;
+				if (position) {
+					overlay = this._getSelectableOverlay(position);
+				}
+				this._onOpenViewContextMenu({ x: br.x + event.clientX, y: br.y + event.clientY, overlay });
 			}
 			else if (!selectedAnnotations.includes(selectableAnnotation)) {
 				this._onSelectAnnotations([selectableAnnotation.id], event);