EPUB: Potentially prevent invalid annotations

src/dom/common/dom-view.tsx

@@ -252,6 +252,12 @@ abstract class DOMView<State extends DOMViewState, Data> {
 
 	protected abstract _updateViewStats(): void;
 
+	protected _getContainingRoot(node: Node): HTMLElement | null {
+		return this._iframeDocument.body.contains(node)
+			? this._iframeDocument.body
+			: null;
+	}
+
 	// ***
 	// Utilities - called in appropriate event handlers
 	// ***
@@ -912,8 +918,12 @@ abstract class DOMView<State extends DOMViewState, Data> {
 				return;
 			}
 			if (annotation.type === 'note') {
+				let root = this._getContainingRoot(oldRange.startContainer);
+				if (!root) {
+					throw new Error('Annotation is outside of root?');
+				}
 				let walker = this._iframeDocument.createTreeWalker(
-					this._iframeDocument.body,
+					root,
 					NodeFilter.SHOW_ELEMENT,
 					node => (isBlock(node as Element) && !node.contains(oldRange!.startContainer)
 						? NodeFilter.FILTER_ACCEPT
@@ -930,7 +940,15 @@ abstract class DOMView<State extends DOMViewState, Data> {
 					walker.previousNode();
 				}
 				newRange.selectNode(walker.currentNode);
-				this._setAnnotationRange(annotation, newRange);
+				try {
+					this._setAnnotationRange(annotation, newRange);
+				}
+				catch (e) {
+					// Reached the end of the section (EPUB)
+					// TODO: Allow movement between sections
+					event.preventDefault();
+					return;
+				}
 				this._options.onUpdateAnnotations([annotation]);
 				this._navigateToSelector(annotation.position, {
 					block: 'center',

src/dom/epub/epub-view.ts

@@ -475,6 +475,11 @@ class EPUBView extends DOMView<EPUBViewState, EPUBViewData> {
 		};
 	}
 
+	protected override _getContainingRoot(node: Node) {
+		return this._sectionRenderers.find(r => r.container.contains(node))?.container
+			?? null;
+	}
+
 	private _upsertAnnotation(annotation: NewAnnotation<WADMAnnotation>) {
 		let existingAnnotation = this._annotations.find(
 			existingAnnotation => existingAnnotation.text === annotation!.text