Fix find popup stuck in infinite loading

zotero · Oct 10, 2024 · 4e070cf · 4e070cf
1 parent 5880f6b
commit 4e070cf
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/src/common/components/view-popup/find-popup.js b/src/common/components/view-popup/find-popup.js
@@ -14,14 +14,17 @@ function FindPopup({ params, onChange, onFindNext, onFindPrevious, onAddAnnotati
 	const inputRef = useRef();
 	const preventInputRef = useRef(false);
 	const [query, setQuery] = useState(params.query);
+	const currentParamsRef = useRef();
+
+	currentParamsRef.current = params;
 
 	const debounceInputChange = useCallback(debounce(value => {
 		if (!inputRef.current) {
 			return;
 		}
 		let query = inputRef.current.value;
-		if (query !== params.query && !(query.length === 1 && RegExp(/^\p{Script=Latin}/, 'u').test(query))) {
-			onChange({ ...params, query, active: true, result: null });
+		if (query !== currentParamsRef.current.query && !(query.length === 1 && RegExp(/^\p{Script=Latin}/, 'u').test(query))) {
+			onChange({ ...currentParamsRef.current, query, active: true, result: null });
 		}
 	}, DEBOUNCE_FIND_POPUP_INPUT), [onChange]);