Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add thumbnails header with page rotation options for web target #110

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

tnajdek
Copy link
Member

@tnajdek tnajdek commented Aug 31, 2023

This PR enables three-dot "more" menu that appears on thumbnails on hover. This works for mouse users, but touch and keyboard will need additional solution(s) but I'm yet to come up with something sensible. Once I figure it out, I'll send another PR.

New implementation described below: #110 (comment)

@tnajdek tnajdek marked this pull request as draft September 1, 2023 10:39
@tnajdek
Copy link
Member Author

tnajdek commented Sep 1, 2023

On a second though I might need to come up with a different UI for this, let's put this on hold for the time being.

@tnajdek tnajdek force-pushed the thumbnails-menu branch 4 times, most recently from d99ed6a to ba28d5e Compare September 1, 2023 22:43
@tnajdek tnajdek changed the title Add three-dot menu for thumbnails for web target Add thumbnails header with page rotation options for web target Sep 1, 2023
@tnajdek
Copy link
Member Author

tnajdek commented Sep 1, 2023

Different approach: I've introduced a header which says n pages selected and contains a button to access to rotate selected pages. This solution is keyboard-accessible and mostly touch-compatible (though there is room for improvement here). There should be no visible change for non-web targets.

Please let me know if this works or if you have any suggestions.

page-rotate.mov

@tnajdek tnajdek marked this pull request as ready for review September 1, 2023 22:59
@mrtcode
Copy link
Member

mrtcode commented Sep 5, 2023

I think the header would be great, but it's not ideal that "1 page selected" is always visible, because rotation and deletion are relatively rare operations.

Also, I guess, multiple thumbnails can't be selected on touch devices, right?

Maybe each thumbnail should have a partially transparent selection button like, for example, in Google Photos web app. Although this would be complicated to implement because at least one thumbnail is always selected.

Anyway, I think for now you can merge this, and we'll improve it in future.

@tnajdek
Copy link
Member Author

tnajdek commented Sep 5, 2023

Similar cases are handled by a dedicated "select" mode on touch devices in web library, i.e. you need to enable "select" mode, at which point each "tap" is adding/removing from selection, instead of navigating to that page - maybe we could do that? And on desktop, leave it as it is in this PR, but maybe remove "1 page selected" unless it's at least 2 pages?

Anyway, I think for now you can merge this, and we'll improve it in future.

I don't have write access to this repo 😅

@dstillman
Copy link
Member

I don't have write access to this repo

Fixed

@tnajdek tnajdek merged commit fe277a7 into zotero:master Sep 11, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants