Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unable to annotate PDFs in a browser on iOS #114

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

tnajdek
Copy link
Member

@tnajdek tnajdek commented Dec 19, 2023

@mrtcode OK to merge this?

While on other devices just using preventDefault is sufficient, on iOS this seems to be required in order to disable scrolling when a tool is selected on iOS.

@tnajdek tnajdek requested a review from mrtcode December 19, 2023 13:12
@mrtcode
Copy link
Member

mrtcode commented Dec 19, 2023

Looks good! Thanks.

@tnajdek tnajdek merged commit 9990297 into master Dec 19, 2023
2 checks passed
@tnajdek tnajdek deleted the fix-pdf-annotations-on-ios branch December 19, 2023 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants