Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase annotations container style specificity #116

Merged
merged 1 commit into from
Dec 22, 2023

Conversation

tnajdek
Copy link
Member

@tnajdek tnajdek commented Dec 22, 2023

Fix #115

Before:

Screenshot 2023-12-22 at 11 43 24

After:

Screenshot 2023-12-22 at 13 01 04

@tnajdek tnajdek requested a review from AbeJellinek December 22, 2023 11:51
@tnajdek tnajdek force-pushed the 115-increase-annotations-style-specificity branch from a4be1d9 to d4e1ec9 Compare December 22, 2023 11:59
@tnajdek
Copy link
Member Author

tnajdek commented Dec 22, 2023

(I've force-pushed a tweak to use a slightly different approach but for the same outcome)

@AbeJellinek
Copy link
Member

Could we also just set !important on all the .annotation-container rules? It's gross, but we really don't want anything to override our styles on this, no matter how specific its selector is.

@tnajdek tnajdek force-pushed the 115-increase-annotations-style-specificity branch from d4e1ec9 to 7147bec Compare December 22, 2023 19:37
@tnajdek
Copy link
Member Author

tnajdek commented Dec 22, 2023

That would work but it's quite gross indeed. I think it should be enough to use an id (which has highest specificity "type") as a selector. I've forced-pushed a tweak that does exactly that.

@AbeJellinek
Copy link
Member

Great, that should do the trick.

@AbeJellinek AbeJellinek merged commit 38f0831 into master Dec 22, 2023
@AbeJellinek AbeJellinek deleted the 115-increase-annotations-style-specificity branch December 22, 2023 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Snapshot annotations invisible on pages that use normalize.css
2 participants