Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Note dissappears when dragged onto another page #119

Closed
wants to merge 1 commit into from

Conversation

xianmin
Copy link

@xianmin xianmin commented Feb 23, 2024

Relate issue: zotero/zotero#3543

@dstillman dstillman closed this Feb 23, 2024
@dstillman dstillman reopened this Feb 23, 2024
@dstillman dstillman requested a review from mrtcode February 23, 2024 07:23
@mrtcode
Copy link
Member

mrtcode commented Feb 23, 2024

It appears the fix enables moving note annotation into another page, which is maybe a good idea but the implementation is far from ready and it breaks text annotation dimensions, doesn't take into account new page label, etc.

For now we only want to prevent moving annotations outside the page. I'll fix this soon.

Anyway, thanks for the help.

@mrtcode mrtcode closed this Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants