Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saving tags in tests different #47

Open
zuphilip opened this issue Oct 1, 2017 · 1 comment
Open

Saving tags in tests different #47

zuphilip opened this issue Oct 1, 2017 · 1 comment
Assignees

Comments

@zuphilip
Copy link
Collaborator

zuphilip commented Oct 1, 2017

It looks that previously in the test cases the tags were simply saved as a list of strings, but now with the newest Zotero 5.0 compatible version the tags are saved as a list of objects of strings. This makes the test result looks different, e.g. tests from ACM translator

"tags": [
-     "calling context tree"
+     {
+       "tag": "calling context tree"
+     }
-     "performance-aware revision control"
+     {
+       "tag": "performance-aware revision control"
+     }
-     "profiling"
+     {
+       "tag": "profiling"
+     }
]

Do we want to continue the new way or switch back to the old way?

@dstillman
Copy link
Member

I fixed the comparison for tests (including in Scaffold, I believe) in zotero/zotero#1254 on the xhr-processDocuments branch of the client, which we'll try to merge soon. But as I noted in zotero/translators#1356 (comment), it's incorrect as an object anyway if it's not including type: 1 (automatic), so if that's still happening we should fix it, and for the sake of readability and conciseness probably just have it return a string (since Zotero RDF is the only case where we'd actually want type: 0).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants