When continued variable is explicitly false, delay is set to be 250ms #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I had a very hard time running it because it seems like uws package is not distributed through npm anymore and there was a mismatch between my node module api and the one wanted by the last available uws package |
dstillman
requested changes
May 8, 2023
server.js
Outdated
| continuedTimeouts[topic] = setTimeout(fn, config.get('noContinuedDelay')); | ||
| } else { | ||
| continuedTimeouts[topic] = setTimeout(fn, config.get('continuedDelayDefault')); | ||
| } |
There was a problem hiding this comment.
House style: Newline between } and else
(Reasoning is that it allows for more logical commenting of an entire else block)
config/default.js
Outdated
| @@ -30,6 +30,7 @@ var config = { | |||
| // Notification action period -- clients are given a randomly chosen delay within this time | |||
| // period before they should act upon the notification, so that we don't DDoS ourselves | |||
| globalTopicsDelayPeriod: 180 * 1000, | |||
| noContinuedDelay: 250, | |||
There was a problem hiding this comment.
noContinuedDelay is a little confusing, since Continued is still passed in that case.
How about continuedDelay (30s), notContinuedDelay (250ms), and defaultDelay (3s)?
|
Moved this to a PR request from feature branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses Issue # 130
When a message has
continued=false, delay is only 250ms