Translator tester: Be more vigilant against empty test cases. #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test cases in a translator script may be empty, not just with an empty array for `var testCases`, but in the sense of completely missing. In that case, don't pass invalid JSON (all whitespaces or empty string) to `JSON.parse()`, and use an empty array instead. This fixes an annoying `SyntaxError` in the console while loading the file `Ovid.js` in the translators repository. That translator should be fixed, too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test cases in a translator script may be empty, not just with an empty array for
var testCases, but in the sense of completely missing.In that case, don't pass invalid JSON (all whitespaces or empty string) to
JSON.parse(), and use an empty array instead.This fixes an annoying
SyntaxErrorin the console while loading the fileOvid.jsin the translators repository. That translator should be fixed, too.