-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add necessary utilities for generic translators #20
base: master
Are you sure you want to change the base?
Conversation
Causes a stack overflow due to circular references when being copied into the sandbox. We should probably make SandboxManager#importObject() deal with circular references without blowing up, but this works for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jsonld.js is this? Is this built fresh or just pulled from node_modules/dist/jsonld.js
after an npm i jsonld
?
In the Connector, do we know if this (large) file gets injected into each webpage/sandbox, or does it just get loaded in the background page/service worker? (@adomasven might be able to comment on this.)
Built fresh. I could add a script to zotero/zotero to do the build if you'd like. It's essentially just |
Yeah, for a large, modified third-party file, particularly one that has to be included in the browser extensions, it's better when we can point to a build script — e.g., so that we can point to that if a reviewer complains about it. (They really prefer unmodified files, but I guess that's not an option here.) Should we just make the |
OK, script added. |
Replaces zotero/zotero#1656