Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve keyboard visible height calculation #1012

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Improve keyboard visible height calculation #1012

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion Zotero/Models/KeyboardData.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,10 @@ struct KeyboardData {
let animationOptions: UIView.AnimationOptions

var visibleHeight: CGFloat {
return UIScreen.main.bounds.height - self.endFrame.minY
// endFrame.height might be 0 for a floating keyboard that is hiding, so return 0 for this case.
// Additionally, floating keyboard will not reach the end of the screen, therefore we can ignore it.
guard endFrame.height > 0, endFrame.maxY >= UIScreen.main.bounds.height else { return 0 }
return UIScreen.main.bounds.height - endFrame.minY
}

init?(userInfo: [AnyHashable: Any]) {
Expand Down